Re: [Rd] R Include File Guards

From: Paul Roebuck <roebuck_at_odin.mdacc.tmc.edu>
Date: Wed 15 Jun 2005 - 21:16:52 GMT

On Wed, 18 May 2005, Peter Dalgaard wrote:

> Paul Roebuck <roebuck@odin.mdacc.tmc.edu> writes:
>
> > R 2.1.0/src/include from 2005/04/18 download
> >
> > Naming inconsistent for guards as well but that's pedantic.
> > Simple convention:
> > file <foo.h>
> > #ifndef R_FOO_H
> > file <R_ext/bar.h>
> > #ifndef R_EXT_BAR_H
> >
> > Missing guards:
> > <IOStuff.h>
> > <Internal.h>
> > <Parse.h>
> > <R_ext/GraphicsBase.h>
> > <R_ext/GraphicsDevice.h>
> > <R_ext/GraphicsEngine.h>
> > <R_ext/R-ftp-http.h>
> > <R_ext/libextern.h>
> >
> >
> > Illegal Guards (leading underscore):
> > <Rinternals.h>
> > <R_ext/Error.h>
> > <config.h.in>
>
> Thanks. The ones outside R_ext, except Rinternals.h, are not part of the
> API, so it is not a bug that there are no guards - could still be a
> good idea to have them of course. libextern.h explicitly says that you
> shouldn't disallow including it more than once. So the ones with real
> problems would be
>
> <R_ext/GraphicsBase.h>
> <R_ext/GraphicsDevice.h>
> <R_ext/GraphicsEngine.h>
> <R_ext/R-ftp-http.h>
>
> <Rinternals.h>
> <R_ext/Error.h>
>
> What's illegal about leading underscores, BTW?
>

I downloaded the R-patched for 2005/06/14 and noticed that the guards were never fixed. Should a bug report have been opened instead of simply noting them here?



SIGSIG -- signature too long (core dumped)

R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel Received on Thu Jun 16 07:19:30 2005

This archive was generated by hypermail 2.1.8 : Mon 20 Feb 2006 - 03:21:09 GMT