Re: [Rd] data frame subset patch, take 2

From: Martin Maechler <maechler_at_stat.math.ethz.ch>
Date: Sat 16 Dec 2006 - 21:31:21 GMT

>>>>> "Vladimir" == Vladimir Dergachev <vdergachev@rcgardis.com> >>>>> on Wed, 13 Dec 2006 13:03:21 -0500 writes:

    Vladimir> On Wednesday 13 December 2006 6:01 am, Martin Maechler wrote:
>>
>> - Vladimir, have you verified your 'take2' against recent versions
>> of R-devel?

    Vladimir> Yes.

indeed it applies cleanly

>> - If they still work, could you re-post them to R-devel, this
>> time using a proper MIME type,
>> i.e. most probably one of
>> application/x-tar
>> application/x-compressed-tar
>> application/x-gzip
>>
>> In case you don't know how to achieve this,
>> I'd be interested to get it by "private" e-mail.

    Vladimir> No problem. The old e-mail did have a mime type: "text/x-diff".
    Vladimir> I am resending the patch - now compressed, hopefully it will get pass whatever 
    Vladimir> filters are in place.

It did pass --- and "text/x-diff" should pass through too from now on.

However, even though the patch looks quite ok {apart from one border case: swiss[2, , drop = TRUE] should give a list;  and that was easy to fix; see the attached dataframe.R-diff  file which incorporates that fix (and my other cosmetic changes)}

but running 'make check-all' then shows segmentation faults --- only on one platform of the two I've tested {in mgcv's gam() example, boot's boot()

                 example, and I think one other place} My guess: typically when dealing with model.frames (which

   internally are "just" data frames with a particular "terms" attribute) but the problems are not reproducible when run interactively. It may really be that .subset() and .subset2() are sometimes used in cases they should not be in your new code; or they even have a bug that is not triggered unless by using them in the new context of [.data.frame

So I'm sorry, but we might have to wait for a "take 3" or rather try to find the problem with your patch. Maybe you can try yourself?

Thanks anyway, Vladimir!

Regards,
Martin Maechler, ETH Zurich



R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel
Received on Sun Dec 17 13:32:16 2006

Archive maintained by Robert King, hosted by the discipline of statistics at the University of Newcastle, Australia.
Archive generated by hypermail 2.1.8, at Sun 17 Dec 2006 - 06:30:54 GMT.

Mailing list information is available at https://stat.ethz.ch/mailman/listinfo/r-devel. Please read the posting guide before posting to the list.