Re: [Rd] C/C++ 'assert' should not be used in R packages

From: Duncan Murdoch <murdoch_at_stats.uwo.ca>
Date: Sat, 10 Nov 2007 06:38:17 -0500

Prof Brian Ripley wrote:
> Please don't use 'assert' in R packages. If called, this means that an
> error in your code aborts the whole R process, including your user's work.
> I see several R packages doing this, and one of them called 'assert' on me
> earlier in the week.
>
I partly disagree about this. If assert() is triggered, it clearly indicates a bug in the package. If it just generated an R error, most users would ignore it, and not report it to the package maintainer.

It may well be that when an assertion fails, none of the subsequent calculations are reliable, in which case returning control to the user could result in data corruption. That's worse than losing a session, because at least when you lose a session, you know it.

Could we write our own implementation of assert() that displays an R error and unloads the package? I think I could do something like that in Windows by calling FreeLibrary to unload the DLL, but I'd prefer a cross-platform solution.
> We provide 'error': please do use it to return control to the user when
> your code misbehaves.
>
> Similarly 'exit' and 'abort' should never be used in R packages.
>
>
> Sometimes it is not under your control: I sometimes see an rgl failure at
>
> R: indirect_vertex_array.c:659: emit_DrawArrays_old: Assertion
> `elements_per_request >= count' failed.
>
> that is coming from the Mesa GL libraries.
>
I'd say that's a bug, either in Mesa GL or in rgl. If you can make it reproducible, I'll try to track it down.

Duncan Murdoch



R-devel_at_r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel Received on Sat 10 Nov 2007 - 11:43:47 GMT

Archive maintained by Robert King, hosted by the discipline of statistics at the University of Newcastle, Australia.
Archive generated by hypermail 2.2.0, at Sun 11 Nov 2007 - 03:30:25 GMT.

Mailing list information is available at https://stat.ethz.ch/mailman/listinfo/r-devel. Please read the posting guide before posting to the list.