[Rd] rgl: bogus configure[.ac] (PR#14183)

From: <jel+r_at_cs.uni-magdeburg.de>
Date: Tue, 12 Jan 2010 16:15:12 +0100 (CET)


Full_Name: Jens Elkner
Version: 2.10.1
OS: Solaris
Submission from: (NULL) (141.44.24.14)

The configure.ac is bogus, since it does not include additional library pathes at the right place and thus fails. E.g.:

$R_HOME/bin/R CMD INSTALL -l $PROTO/R/library \

    --configure-args='--with-gl-includes=/usr/X11/include/NVIDIA --with-gl-libs=/usr/X11/lib/NVIDIA/amd64' $TMPBUILD

And thus configure tries: cc ... -lGL -L/usr/X11/lib/NVIDIA/amd64 which obviously fails: the path needs to be placed before -l... So the correct way is to add the path to LD_FLAGS instead of LIBS.

To get the path at the correct place into the to PKG_LIBS limitted Makevars, one
needs to add the path, when the LIB expansion has been done. Suggested patch:

 AC_ARG_WITH(gl-libs,

 [  --with-gl-libs=DIR      specify location of OpenGL libs],
-[LIBS="${LIBS} -L${withval}"]
+[LDFLAGS="${LDFLAGS} -L${withval}"

+L_LIB="-L${withval}"
+]
 )  

+
 AC_ARG_WITH(gl-libname,
 [ --with-gl-libname=NAME specify Library name (defaults to "GL")],  [lGL=${withval}], [lGL=GL]
@@ -179,6 +182,9 @@

 if test "x$this" != xyes; then
   AC_ERROR([missing required library ${lGLU}])  fi

+if test x$L_LIB != x; then
+   LIBS="${L_LIB} ${LIBS}"
+fi
 
 ## --- FTGL ------------------------------------------------------------------

______________________________________________
R-devel_at_r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel Received on Tue 12 Jan 2010 - 15:19:52 GMT

Archive maintained by Robert King, hosted by the discipline of statistics at the University of Newcastle, Australia.
Archive generated by hypermail 2.2.0, at Tue 12 Jan 2010 - 17:10:13 GMT.

Mailing list information is available at https://stat.ethz.ch/mailman/listinfo/r-devel. Please read the posting guide before posting to the list.

list of date sections of archive