Re: [Rd] src/library/grid/src/grid.c (PR#14199)

From: Peter Dalgaard <P.Dalgaard_at_biostat.ku.dk>
Date: Thu, 28 Jan 2010 16:23:26 +0100

A.R.Runnalls_at_kent.ac.uk wrote:
> At around line 2590, in function gridRect() in
> src/library/grid/src/grid.c (at the latest svn revision, 50745), ought
> not temp, www and hhh to be PROTECTed within this block?

Plausible, provided that anything can allocate while those are being used. Could you perhaps investigate that a little further? (Bug reports should really contains exclamation points and not question marks...)

If unit() can allocate, then all constructs like

2565                 www = unit(xadj, L_INCHES);
2566                 hhh = unit(yadj, L_INCHES);

are equally dubious.

Oh, never mind, unit() definitely allocates, so of course you are right!

-- 
   O__  ---- Peter Dalgaard             Ă˜ster Farimagsgade 5, Entr.B
  c/ /'_ --- Dept. of Biostatistics     PO Box 2099, 1014 Cph. K
 (*) \(*) -- University of Copenhagen   Denmark      Ph:  (+45) 35327918
~~~~~~~~~~ - (p.dalgaard_at_biostat.ku.dk)              FAX: (+45) 35327907

______________________________________________
R-devel_at_r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel
Received on Thu 28 Jan 2010 - 15:27:02 GMT

Archive maintained by Robert King, hosted by the discipline of statistics at the University of Newcastle, Australia.
Archive generated by hypermail 2.2.0, at Thu 28 Jan 2010 - 22:00:17 GMT.

Mailing list information is available at https://stat.ethz.ch/mailman/listinfo/r-devel. Please read the posting guide before posting to the list.

list of date sections of archive