R-alpha: buglets

Ross Ihaka (ihaka@stat.auckland.ac.nz)
Tue, 12 Nov 1996 17:13:50 +1300 (NZDT)


From: Ross Ihaka <ihaka@stat.auckland.ac.nz>
Date: Tue, 12 Nov 1996 17:13:50 +1300 (NZDT)
Message-Id: <199611120413.RAA25707@stat13.stat.auckland.ac.nz>
To: r-testers@stat.math.ethz.ch
Subject: R-alpha: buglets
In-Reply-To: <9611080048.AA10836@yarra.vut.edu.au.vut.edu.au>

Robert Dunne writes:
 > hi,
 >    here are some little things if have notices with the fortran option
 > in 0.13.
 > 
 > 1)line 34 in src/appl/uncmin.f reads
 >       STEP(I)=ETA*AMAX1(X(I),TYPX(I)) 
 > however AMAX1 returns the maximum of a set of reals -- X and TYPX are
 > of type double -- therefore it should read 
 >       STEP(I)=ETA*DMAX1(X(I),TYPX(I))
 >                   ^ 
 > Some compilers give an error (dec) and some don't (sun).
 > I dont know what will happen at runtime.
 >
 > 3) on some compilers (g77) there are a lot of warnings such as
 > 
 > uncmin.f:2162: warning:
 >          CALL DFAULT(N,X,WRK(1,4),FSCALE,METHOD,IEXP,MSG,NDIGIT,
 >                                ^
 > Array element value at (^) out of defined range
 > 
 > as WRK was dimensioned as WRK(NR,1) 
 > 
 > This could be a coding mistake or it could be an "assumed size array".
 > The change 
 >        DIMENSION A(NR,*),WRK(NR,*)
 > fixes the error messages, but perhaps it is safe just to ignore them.
 > any ideas?

This is a vanilla version of the Schnabel UNCMIN code from NETLIB and
I'm a little nervous about tinkering with it too much.  I can
certainly fix the AMAX1/DMAX1 problem, but so long as only warnings
result from the array dimensioning, I'm inclined to leave things as
they are.  (This is a standard fortran-66 trick I think).

 > 2) in config.site and src/appl/Makefile.in, the fortran compiler is
 > callled F77. This should probably be called FC (fortran compiler), as 
 > this is the variable used in the implicit make rule for compiling fortran
 > programs. 

Is this universal?  This was my reason for using F77.
	Ross
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
r-testers mailing list -- To (un)subscribe, send
subscribe	or	unsubscribe
(in the "body", not the subject !)  To: r-testers-request@stat.math.ethz.ch
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-