Re: [Rd] Possible bug in termplot function (stats package) ?

From: Joris Meys <jorismeys_at_gmail.com>
Date: Mon, 06 Jun 2011 20:38:48 +0200

On Mon, Jun 6, 2011 at 6:29 PM, peter dalgaard <pdalgd_at_gmail.com> wrote:
>
> On Jun 6, 2011, at 17:15 , Joris Meys wrote:
>
**snip**
>> If nothing is found, an error is returned. If
>> anything is found, data won't be NULL, so line 20, when reached, will
>> always return FALSE. Can it be that lines 18 and 19 should be removed
>> from the function?
>
>
> I think this is a false assumption. What keeps model$call$data from being NULL?
>
Apart from a dataframe that is explicitly assigned NULL, I can't imagine a case where model$call$data would be NULL. If it's not found, the statement returns an error. If it is found and it is NULL, your model call will have thrown an error earlier, so you won't even have an object to plot. If you can give me one example where that code actually makes sense, I'll be very happy. But right now, it doesn't make any sense at all to me.

> No comments on the remainder, except that it wouldn't be the first time a wrapper function got into trouble with environments and modelling functions...
>
My wrapper function returns a completely sound lm-object. Why wouldn't I expect a function built to work on lm-objects to work on an lm-object? At least the help files should note that the dataframe will be sought in the calling environment, or it won't work on your fitted objects.

Right now I have to do something like :

termplot.wrapper <- function(x,...){

    x$call$data <- NULL
    termplot(x)
}

which seems at least a tiny bit awkward...

Cheers
Joris

-- 
Joris Meys
Statistical consultant

Ghent University
Faculty of Bioscience Engineering
Department of Applied mathematics, biometrics and process control

tel : +32 9 264 59 87
Joris.Meys_at_Ugent.be
-------------------------------
Disclaimer : http://helpdesk.ugent.be/e-maildisclaimer.php

______________________________________________
R-devel_at_r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel
Received on Mon 06 Jun 2011 - 18:42:01 GMT

This quarter's messages: by month, or sorted: [ by date ] [ by thread ] [ by subject ] [ by author ]

All messages

Archive maintained by Robert King, hosted by the discipline of statistics at the University of Newcastle, Australia.
Archive generated by hypermail 2.2.0, at Mon 06 Jun 2011 - 19:40:17 GMT.

Mailing list information is available at https://stat.ethz.ch/mailman/listinfo/r-devel. Please read the posting guide before posting to the list.

list of date sections of archive